Fuse iterators in InterleaveShortest#872
Fuse iterators in InterleaveShortest#872phimuemue wants to merge 1 commit intorust-itertools:masterfrom
Conversation
This brings InterleaveShortest in line with Interleave. The documentation already (incorrectly) stated that InterleaveShortest is fused.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
==========================================
- Coverage 94.38% 94.28% -0.11%
==========================================
Files 48 48
Lines 6665 6665
==========================================
- Hits 6291 6284 -7
- Misses 374 381 +7 ☔ View full report in Codecov by Sentry. |
|
I started an investigation ("blame" in the web pages of our code is even more powerful than I thought (for each line, we can have navigate its history)): |
I'm fine with either unfused or fused, but I'd vote for uniform behavior. Not sure if we have a general guideline regarding fusedness, though. |
I agree. |
|
I'm gonna make an issue about fusedness to see opened issues and PRs related to it, clarify the situation (like make a guideline) and eventually make a TODO list about all this. |
In my book,
InterleaveShortestshould not produce more items thanInterleave, but so far it did for unfused source iterators.This PR brings
InterleaveShortestin line with Interleave. The documentation already (incorrectly) stated thatInterleaveShortestis fused.Related to #533.